[webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform
mjs at apple.com
Thu Feb 28 13:02:07 PST 2013
I think Adam's old plan for the Platform directory was to migrate from WebCore/platform piece-by-piece, starting with related groups of classes that are already free of layering violations. That seems like a sensible approach to me as it allows the work to happen incrementally.
On Feb 28, 2013, at 12:41 PM, Žan Doberšek <zandobersek at gmail.com> wrote:
> On Thu, Feb 28, 2013 at 6:31 PM, Darin Adler <darin at apple.com> wrote:
> There may be a misunderstand of what the “platform layer” is.
> We should not move all platform-specific files into the platform directory! Please do not make the changes in bug 110330 until we have discussed this.
> The idea is not that all platform-specific code is in the WebCore/platform directory. Instead, the idea is that WebCore/platform contains code that the rest of WebCore is built on top of that creates a platform independent abstraction.
> To do this, we need to eliminate dependencies from the platform directory to the rest of WebCore.
> At this time, we are far from that. Many dependencies on the DOM and other such things have crept into the platform directory.
> The real point of having a separate library for the platform directory is not to segregate all platform-specific code, but rather to have a coherent platform independence library that we can rely on for most platform-independence and minimize the need for platform-independent code.
> -- Darin
> Understood. Thanks for the explanation, much appreciated. Will held off the work for the GTK-specific files until appropriate.
> For the sake of clarity and if in anyone's interest, I'm linking two more bugs:
> https://bugs.webkit.org/show_bug.cgi?id=21354 - meta bug for platform layering violations
> https://bugs.webkit.org/show_bug.cgi?id=75664 - meta bug for the platform layer migration
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev