[webkit-dev] Best practices for landing new/changed layout test expectations?

Dirk Pranke dpranke at chromium.org
Tue Feb 26 12:47:30 PST 2013


On Tue, Feb 26, 2013 at 2:11 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Tue, Feb 26, 2013 at 1:55 AM, Tom Hudson <tomhudson at google.com> wrote:
>>
>> On Mon, Feb 25, 2013 at 10:34 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>>
>>> It should be fairly straight forward to create a tool that analyzes files
>>> changed in each commit and deduce which tests' expected results have been
>>> changed. The tool can then fetch results from each port' bot for those tests
>>> and automatically land them. It can then comment on the bug automatically
>>> about these rebaseline commits. There is no need to add & remove entries
>>> from TestExpectation files.
>>

Wait, what?

For some reason neither I nor the mailing list archives got your
initial message, nor  Silvia or Tom's responses, nor your responses
(at least as of the time of me writing this), so I feel like I've
missed a radical shift in this thread, and maybe I missed some of the
context.

You're proposing that we automatically land updated baselines without
review and then somehow update bugs, have people go back and look at
the updated bugs to see if the baseline changes represent actual
regressions or just expected changes? Can you walk me through how this
would work in more detail?

-- Dirk


More information about the webkit-dev mailing list