[webkit-dev] Best practices for landing new/changed layout test expectations?
rniwa at webkit.org
Mon Feb 25 13:33:13 PST 2013
On Mon, Feb 25, 2013 at 1:29 PM, Dirk Pranke <dpranke at google.com> wrote:
> On Mon, Feb 25, 2013 at 1:22 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> > On Mon, Feb 25, 2013 at 12:52 PM, Dirk Pranke <dpranke at google.com>
> >> > I remember some discussion of a [rebaseline] keyword in
> >> > TestExpectations,
> >> > but I'm not sure that ever made it in?
> >> The [ NeedsRebaseline ] enhancement is, as of yet, unimplemented and
> >> unclaimed . It shouldn't be too hard for someone to try it if
> >> they're looking for a reason to explore the NRWT code :)
> > I object to adding such a thing. People add and forget about these
> > way too often:
> The rationale for adding the keyword was precisely this ... it would
> make it easier to programmatically identify tests needing updated
> baselines and alert people :).
> Do you have an alternative you'd suggest for keeping people from
> forgetting (particularly in the case where we have an expected failure
> waiting on a bug fix)?
Just turn bots red. People maintaining bots will notice and rebaseline them
- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev