[webkit-dev] How to get patch test at different platform before webkit-patch upload

徐征 xz911jp at yahoo.co.jp
Sun Feb 17 03:09:37 PST 2013

Hi, Benjamin

Thank you so much for advice and review.
You are right that we can not expect different platform to render as 
same pixel images.

I have modified source code based on comment.
And modified TestExpectations(add line such as following) for chromium, 
gtk, win and qt.

# Needs rebaseline because platform-specific
webkit.org/b/78957 fast/text/decorations-with-ruby-underline-expand.html 
[ Failure ]

Thank you again and looking forward review result.


(2013/02/17 11:07), Benjamin Poulain wrote:
> Hi,
> On Sat, Feb 16, 2013 at 5:45 PM, 徐征 <xz911jp at yahoo.co.jp 
> <mailto:xz911jp at yahoo.co.jp>> wrote:
>     I am handling this issue
>     (https://bugs.webkit.org/show_bug.cgi?id=78957)
>     now.
>     My question is I test my added test code locally, however, it seems
>     failed on some other platform(get red on cr-linux).
>     So can I(and how can I) test my added test code on some EWS before I
>     upload some patch?
> The cr-linux bot is the only EWS running the pixel tests. Your test 
> likely fails on everything but Mac.
> The problem is you assume the pixel test will be the same on all 
> platform. Because the way fonts are rendered varies, the resulting 
> images vary with each platform.
> In those cases, you can generate results for the platform you are 
> working on, and mark the test for rebaseline in the "TestExpectations" 
> files of the other platforms (in 
> LayoutTest/platform/platformFooBar/TestExpectations).
> Cheers,
> Benjamin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130217/dbe8ffd6/attachment.html>

More information about the webkit-dev mailing list