[webkit-dev] Controlling use of Deletion UI with ENABLE_DELETION_UI

Maciej Stachowiak mjs at apple.com
Mon Feb 11 17:11:04 PST 2013

On Feb 11, 2013, at 4:23 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Mon, Feb 11, 2013 at 3:53 PM, Enrica Casucci <enrica at apple.com> wrote:
> with http://trac.webkit.org/changeset/142533 I've added the ability to control the use of the Deletion UI.
> I've explicitly enabled the feature for MAC and disabled it for iOS but I left in on by default for all the other ports, since I wasn't sure if how other WebKit clients were using it.
> I suspect many ports use it only in the tests. If this is the case I would encourage every port to take explicit action and decide whether this is something you want or not.
> You forgot to mention that you did this as a part of upstreaming iOS code :)
> I'm going to move delete button controller tests to platform/mac and delete corresponding code in non-Mac ports.

Would it be worthwhile to make the editing deletion UI runtime switchable instead, so the behavior with it on and off can be tested on all ports?

 - Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130211/e208a25c/attachment.html>

More information about the webkit-dev mailing list