[webkit-dev] [MIPS] Still more requests for review - MIPS buildbot is failing

Gergely Kis gergely at homejinni.com
Mon Feb 11 16:15:51 PST 2013


Dear Webkit Developers,

Unfortunately the MIPS buildbot was failing for a few weeks now, because
some of our patches are not getting reviewed.

The current list is shown below:

1. DFG JIT implementation:
https://bugs.webkit.org/show_bug.cgi?id=101328

We got some reviews earlier, those comments have been fixed already. We
even provided 2 variants for the setupArguments* handling: inline function
and macro based, so you can decide which one you like better. (or just
propose a different solution.)

2. atomicIncrement implementation for MIPS:
https://bugs.webkit.org/show_bug.cgi?id=106739

We implemented the builtin that was missing from the MIPS toolchains.
Waiting for review here as well.

3. REGRESSION(r140594): It made 2 tests crash on MIPS
https://bugs.webkit.org/show_bug.cgi?id=108662

This commit is fixed in the DFG JIT patch: the missing methods are already
implemented there.

Could you please help us in getting these patches accepted and making the
MIPS buildbot green again?

Thank you for your help.

Best Regards,
Gergely
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130212/777c5ee9/attachment.html>


More information about the webkit-dev mailing list