[webkit-dev] Can Qt use some of the common DRT code?

[Jochen Eisinger]

On Mon, Feb 11, 2013 at 8:19 AM, Benjamin Poulain <benjamin at webkit.org>wrote:

> On Sun, Feb 10, 2013 at 10:56 PM, Jochen Eisinger <jochen at chromium.org>wrote:
>
>> Today, adding a support for a new function in TestRunner requires
>>> (painfully) changing:
>>> -WebKitTestRunner.
>>> -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry).
>>> -Chromium DRT.
>>> -Qt DRT.
>>> I think we can do much better. A first step is to have more common code
>>> in DRT.
>>>
>>
>> Another option is to add the new functionality to window.internals, and
>> only change DRT for test code that is port specific or supposed to test a
>> port's WebKit API.
>>
>
> Isn't that what we already do?
> If someone intentionally choose DRT over internals, she/he is courageous :)
>

I'm not sure I understand. In what cases do you then add something to DRT
and need to change all of them?

best
-jochen


>
> Benjamin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130211/82e9495a/attachment.html>