[webkit-dev] Test frame size for reftests

[Zoltan Horvath]

Yes, that be would the cleanest solution. If there is no concerns against
it, I'm going to file a bug.

<Zoltan>


On Tue, Apr 23, 2013 at 11:36 AM, Benjamin Poulain <benjamin at webkit.org>wrote:

> Hi,
>
> On Tue, Apr 23, 2013 at 11:26 AM, Zoltan Horvath <zoltan at webkit.org>wrote:
>
>> I was debugging a test which was passing in the testrunner, but failing
>> in the testbrowser. It was because the reftests compare only in a 800*600px
>> frame, although we have many tests which are taller than this frame. If
>> there was a mismatch to the expected result outside that frame and the
>> difference doesn't affect the scrollbar then the test just passes silently.
>>
>> Do we have any guidelines for these cases?
>>
>> We could either:
>>
>> 1. Split up the tests concerned.
>> 2. Increase the test frame size to a bigger fixed value. (I'm thinking
>> only in reftests.)
>> 3. Generate the images for the actual view. (?)
>> 4. ?
>>
>> Any thoughts?
>>
>
> I am happy you are looking into this issue! This has been bothering me for
> a while :)
>
> The current mode works fine for some ref-tests but is really annoying for
> others. I would love to have a way to compare the entire page instead of
> the viewport.
>
> Maybe it could just be an API on testrunner? Like:
>     testRunner.dumpEntirePagePixels()?
>
> Benjamin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130423/cb8e82f3/attachment.html>