[webkit-dev] restricting the number of new windows created in response to a user gesture

Jochen Eisinger jochen at chromium.org
Fri Apr 12 14:03:16 PDT 2013

On Fri, Apr 12, 2013 at 10:58 PM, Benjamin Poulain <benjamin at webkit.org>wrote:

> On Fri, Apr 12, 2013 at 5:05 AM, Jochen Eisinger <jochen at chromium.org>wrote:
>> currently, WebKit allows for an arbitrary number of new windows to be
>> created in response to a single user gesture. This is "used" for example to
>> create pop-unders.
>> In order to restrict the number of new windows to one per user gesture, a
>> port needs to invoke UserGestureIndicator::consumeUserGesture() in it's
>> ChromeClient::createWindow method.
>> In https://bugs.webkit.org/show_bug.cgi?id=114379 I add this for WK2 and
>> for WK1 mac/win.
>> Are other ports interested in this behavior? If not, I'd just skip the
>> corresponding tests.
> I am confused.
> Why do you want to add something even in the case no port would be
> interested?

If indeed no port is interested, I would instead remove the consumable user
gesture code (since it was only used by chromium).


> Benjamin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130412/d7ec2dcf/attachment.html>

More information about the webkit-dev mailing list