[webkit-dev] Baselines ignoring metrics
rniwa at webkit.org
Wed Sep 19 13:08:22 PDT 2012
As ossy has suggested in the bug, we should just convert those tests that
don't require metrics equivalency to dumpAsText tests.
On Sep 19, 2012 2:53 AM, "Allan Sandfeld Jensen" <kde at carewolf.com> wrote:
> Hello WebKit,
> Some time ago I wrote a patch that would make the test runners detect
> that had been generated with the --ignore-metrics flag, see
> https://bugs.webkit.org/show_bug.cgi?id=94815 . This makes it possible to
> generate baselines that would always be testing ignoring metrics, and which
> would help consolidate more expected results between platforms - see the
> second patch in the bug for an example of that.
> The cases I expect this to make sense in, are tests for css selectors,
> and other places the final layout is not part of what is being tested.
> such new tests should be written using dumpText, but we have many old test-
> cases that has not been written that way, and many more that are imported
> from external test suites which never will be.
> Should we apply the patch and start using ignore-metric baselines, and
> we make some guidelines for what kind of tests this should be allowed on?
> Best regards
> `Allan Sandfeld
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev