[webkit-dev] unsigned vs unsigned int

[Oliver Hunt]

Does the style bot pick up "unsigned int" etc?

--Oliver

On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!)
> 
> On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682.
> 
> - Ryosuke
> 
> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein <mitz at apple.com> wrote:
> 
> 
> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen <kenneth.christiansen at gmail.com> wrote:
> 
> > Hi there,
> >
> > I was telling people to use "unsigned" instead of "unsigned int", as I
> > have been told that was the preferred style before, but apparently
> > that is not in the style guide.
> >
> > The question is, should it be?
> 
> Yes.
> 
> >
> > A few greps in the code:
> >
> > "unsigned" -> 18406 occurrences.
> > "unsigned int" -> 1721
> > "unsigned i =" -> 1548
> >
> > It does in fact seem to be the preferred style.
> >
> > Cheers
> > Kenneth
> >
> > --
> > Kenneth Rohde Christiansen
> > Senior Engineer, WebKit, Qt, EFL
> > Phone  +45 4093 0598 / E-mail kenneth at webkit.org
> >
> > ﹆﹆﹆
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120913/76392ac2/attachment.html>