[webkit-dev] link error when adding code to WebCore/testing/InternalSettings.cpp

[Sailesh Agrawal]

Yep, that was perfect. I need to add the symbol
to symbols.filter, WebKit2.def, and WebKit2CFLite.def.

I also looked at this similar patch:
https://bugs.webkit.org/attachment.cgi?id=162752&action=prettypatch

Thanks Adam and Kentaro!

On Sat, Sep 8, 2012 at 5:30 PM, Kentaro Hara <haraken at chromium.org> wrote:

> This wiki page might be helpful:
> http://trac.webkit.org/wiki/ExportingSymbols
>
>
>
> On Sun, Sep 9, 2012 at 8:58 AM, Adam Barth <abarth at webkit.org> wrote:
> > Take a look at other patches that have added similar code to
> > InternalSettings.  You need to export the symbol by hand for the
> > apple-win port as well.
> >
> > Adam
> >
> >
> > On Sat, Sep 8, 2012 at 4:52 PM, Sailesh Agrawal <sail at chromium.org>
> wrote:
> >> Hi all.
> >>
> >> I'm having trouble fixing link errors due to the following code that I
> added
> >> to WebCore/testing/InternalSettings.cpp:
> >> void InternalSettings::setUsesOverlayScrollbars(bool flag)
> >> {
> >>     settings()->setUsesOverlayScrollbars(flag);
> >> }
> >>
> >> This gives me the following link error:
> >> 23>WebCoreTestSupport.lib(InternalSettings.obj) : error LNK2019:
> unresolved
> >> external symbol "public: static void __cdecl
> >> WebCore::Settings::setUsesOverlayScrollbars(bool)"
> >> (?setUsesOverlayScrollbars at Settings@WebCore@@SAX_N at Z) referenced in
> function
> >> "public: void __thiscall
> >> WebCore::InternalSettings::setUsesOverlayScrollbars(bool)"
> >> (?setUsesOverlayScrollbars at InternalSettings@WebCore@@QAEX_N at Z)
> >>
> 23>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll :
> >> fatal error LNK1120: 1 unresolved externals
> >>
> >> I tried exporting Settings::setUsesOverlayScrollbars in WebCore.exp.inbut
> >> this doesn't seem to have helped.
> >>
> >> Does anyone know what I'm missing?
> >>
> >> The full patch and error logs are here:
> >> https://bugs.webkit.org/show_bug.cgi?id=96049
> >>
> >> Thanks!
> >> Sailesh
> >>
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo/webkit-dev
> >>
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo/webkit-dev
>
> --
> Kentaro Hara, Tokyo, Japan (http://haraken.info)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120908/2283218a/attachment.html>