[webkit-dev] DRT/WTR should clear the cache at the beginning of each test?
rniwa at webkit.org
Sun Oct 28 18:57:51 PDT 2012
On Sun, Oct 28, 2012 at 4:37 PM, Dirk Pranke <dpranke at chromium.org> wrote:
> On Sun, Oct 28, 2012 at 2:47 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> > On Sun, Oct 28, 2012 at 2:09 PM, Dirk Pranke <dpranke at chromium.org>
> >> > On Oct 26, 2012, at 11:11 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> >> >> I’m sure Antti, Alexey, and others who have worked on the loader and
> >> >> other parts of WebKit are happy to write those tests or list the
> kind of
> >> >> things they want to test. Heck, I don’t mind writing those tests if
> >> >> could make a list.
> >> >>
> >> >> I totally sympathize with the sentiment to reduce the test flakiness
> >> >> but loader and cache code have historically been under-tested, and
> we’ve had
> >> >> a number of bugs detected only by running non-loader tests
> >> >>
> >> >> On the contrary, we’ve had this DRT behavior for ages. Is there any
> >> >> reason we can’t wait for another couple of weeks or months until we
> add more
> >> >> loader & cache tests before making the behavior change?
> >> >
> >> Please correct me if I'm misinformed, but it's been three months since
> >> this issue was first raised, and it doesn't sound like they've been
> >> writing those tests or are happy to do so, and despite people asking
> >> on this thread, they haven't been listing the kinds of tests they
> >> think they need.
> > I don't think anyone else had suggested adding tests as an option or set
> > deadline until I suggested yesterday (or when I did in my original reply
> > the thread). In fact, since Ami posted his reply on October 26th 1:20AM
> > (PST), many contributors from non-PST timezones haven't even had a
> chance to
> > read his post during normal business hours.
> > Given that I'd think it's totally unreasonable to land the patch as is
> > without giving people reasonable amount of time (~one week) to respond to
> > this thread.
> Both you and Eric U suggesting adding new tests for this in the
> original thread on 8/9; in fact, this whole issue got a fair amount of
> discussion then, and this round hasn't really added anything new.
Yeah, but I don't think it got much traction back then. Also, we didn't
have any deadlines like weeks or months.
I'm happy to wait a little longer if others want to come up with some
> other suggestions; I apologize if my previous response sounded like I
> was throwing down a gauntlet or otherwise not open to ideas; that was
> definitely not my intent.
> Rather, I was attempting to say that unless someone else has other
> ideas, the right path forward seems fairly clear to me and that I
> intended to proceed down it.
> Does that seem more reasonable to you?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev