[webkit-dev] DRT/WTR should clear the cache at the beginning of each test?
rniwa at webkit.org
Sun Oct 28 14:47:00 PDT 2012
On Sun, Oct 28, 2012 at 2:09 PM, Dirk Pranke <dpranke at chromium.org> wrote:
> > On Oct 26, 2012, at 11:11 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> >> I’m sure Antti, Alexey, and others who have worked on the loader and
> other parts of WebKit are happy to write those tests or list the kind of
> things they want to test. Heck, I don’t mind writing those tests if someone
> could make a list.
> >> I totally sympathize with the sentiment to reduce the test flakiness
> but loader and cache code have historically been under-tested, and we’ve
> had a number of bugs detected only by running non-loader tests
> >> On the contrary, we’ve had this DRT behavior for ages. Is there any
> reason we can’t wait for another couple of weeks or months until we add
> more loader & cache tests before making the behavior change?
> Please correct me if I'm misinformed, but it's been three months since
> this issue was first raised, and it doesn't sound like they've been
> writing those tests or are happy to do so, and despite people asking
> on this thread, they haven't been listing the kinds of tests they
> think they need.
I don't think anyone else had suggested adding tests as an option or set a
deadline until I suggested yesterday (or when I did in my original reply to
the thread). In fact, since Ami posted his reply on October 26th 1:20AM
(PST), many contributors from non-PST timezones haven't even had a chance
to read his post during normal business hours.
Given that I'd think it's *totally unreasonable to land the patch as
is*without giving people reasonable amount of time (~one week) to
So unless someone can convince me that there is actually a plan and a
> timeline for resolving (1) and (3) that we can expect to happen and
> that I should just wait a little while longer, I plan to R+ Ami's
> change so he can land it for the ports that do want it. I believe we
> are inflicting more harm on the project as a whole by not doing so.
While having single behavior across all DRTs will be nice, GTK+ and EFL
DRTs already clear cache between tests as far as I know. Given this,
changing the Chromium DRT's behavior to align those two ports seems like a
reasonable move. However, I still strongly believe that we haven't given
many contributors enough time to think about the problem yet.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev