[webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

Antti Koivisto koivisto at iki.fi
Fri Oct 26 01:44:25 PDT 2012


On Wed, Aug 8, 2012 at 9:54 PM, Eric U <ericu at google.com> wrote:

> On Wed, Aug 8, 2012 at 11:43 AM, Alexey Proskuryakov <ap at webkit.org>
> wrote:
> > I can see some downsides to emptying the cache before each test:
> >
> > - we won't be getting any test coverage for cache behavior when it hits
> > non-trivial size;
>
> Then let's add a cache test explicitly for this.  Otherwise we just
> have to hope it gets tested accidentally along the way.
>

Cache has subtle interactions with other things being tested (->flakiness).
More explicit cache tests would be nice but we can't hope the replicate all
the accidental testing we now get. We are going to lose a large chunk of
existing test coverage if we do this.


  antti


>
> > - this may well make tests measurably slower;
> >
> > - this will be yet another cause of subtle difference between platforms,
> as
> > some will undoubtedly have this unimplemented for a long time.
>
> Both good points, but probably worth it, given the reliability
> improvement in the tests IMO.
>
>         Eric
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121026/d96705e6/attachment.html>


More information about the webkit-dev mailing list