[webkit-dev] Tips on why run-webkit-tests is not working for me?
Eric Seidel
eric at webkit.org
Wed Oct 3 15:49:16 PDT 2012
I should note that webkit-patch does do some magic to find it's
checkout. Its possible it's somehow confused by your svn setup? I
don't personally use the svn codepaths very often.
In case this is useful, here is some more context on what webkitpy is
trying to do:
Most webkitpy clients, including webkit-patch, create a Host object:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/host.py#L128
which includes an "SCM" object, which is created by looking for your
checkout_root via the SCMDetector:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/detection.py#L44
In your case it likely decides it's SVN:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py#L85
and then walks up to find the root of the checkout:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py#L112
It has some fancy logic to handle nested SVN checkouts.
This is designed to emulate the "wkdirs.pm" behavior from all the
perl-scripts of yor. (I really like that I can run build-webkit from
any command-prompt and have it do the right thing. webkit-patch tries
to behave the same.)
On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler <darin at apple.com> wrote:
> On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion.
>
> My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script inside the ~/Safari/OpenSource directory.
>
> On Oct 3, 2012, at 9:11 AM, Ojan Vafai <ojan at chromium.org> wrote:
>
>> I'm guessing there's something about your checkout that is confusing the code that finds the path to run-webkit-tests. Does /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/run-webkit-tests actually exist or is that path incorrect?
>
> That path is correct, although I don’t know where it’s coming from. Maybe related to how I originally checked out my tree from Subversion.
>
> On Oct 3, 2012, at 9:19 AM, Eric Seidel <eric at webkit.org> wrote:
>
>> It looks like it's in Mac._build_java_test_support:
>
> I don’t think I have Java installed on this computer. Maybe that’s somehow related to the problem.
>
>> I would suggest running "test-webkitpy" (which will go through and delete any orphaned .pyc files which could be confusing things).
>
> OK, I’ll do that when I get a chance.
>
>> Perhaps make is missing?
>
> I often use make from the command line to build, so it’s in my path.
>
> I wish the error message made it clearer what file couldn’t be found. The thing that changed most recently on my machine is how Xcode is installed, so I’m guessing the problem is somehow related to that, since I’ve run the tests many times in the past.
>
> -- Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
More information about the webkit-dev
mailing list