[webkit-dev] WebKit + OpenCL

[Dirk Schulze]

On Nov 23, 2012, at 2:43 PM, Andreas Kling <akling at apple.com> wrote:

> Hi folks,
> 
> Do we really think it's a good idea to add yet another implementation of filters?
> 
> We already have generic, NEON-optimized and WTF::ParallelJobs (which includes generic, OpenMP and libdispatch backends) implementations of this code, and now we're adding OpenCL too.
> 
> On the WebKit Project Goals page <http://www.webkit.org/projects/goals.html>, it states that:
> 
> "WebKit is an engineering project not a science project. For new features to be adopted into WebKit, we strongly prefer for the technology or at least the use case for it to be proven."
> 
> Correct me if I'm wrong, but we don't see much use of these features on the web. I understand that there's a bit of a chicken/egg problem where a feature won't be interesting to content creators until it performs well enough, but it seems like we could at least decide on a single path forward instead of repeatedly forking the code.

I designed the current SVG Filters implementation in a way that hopefully make it possible to implement HW accelerated filters on top of it. Skia and NEON already go this path. I am not defending the OpenCL implementation for SVG Filters per se, but different platform dependent solutions were expected and wanted. Software filters were designed to be a fallback if an implementation does not provide HW acceleration (yet). I hope that we see a Core Image version of filters in the near future as well. The code for that is in the history of the repository already.

Greetings,
Dirk

> 
> -Kling
> 
> On Nov 21, 2012, at 7:30 PM, Zoltan Herczeg <zherczeg at webkit.org> wrote:
> 
>> Hi,
>> 
>> we start upstreaming some OpenCL optimizations into WebKit.
>> 
>> This is the master bug:
>> https://bugs.webkit.org/show_bug.cgi?id=70099
>> 
>> Regards,
>> Zoltan
>> 
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev