[webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

Mike Lawther mikelawther at google.com
Thu Nov 15 16:28:12 PST 2012

On 16 November 2012 09:59, Ryosuke Niwa <rniwa at webkit.org> wrote:

> While I don’t want to further agitate the issue or go off on a tangent,
> and agree that we must address the security aspect before getting rid of
> RenderArena, only WebKit reviewers can r- patches written by other
> contributors. You’re not even supposed to set r- on your own patches. See
> http://www.webkit.org/coding/commit-review-policy.html

I see that page says 'Note that you should not put r+ nor r- on patches in
such unofficial reviews' with respect to a non-reviewer doing a shadow

I can't see the extrapolation from that to 'you can't r- your own patches'.
I thought r-'ing your own patch was a relatively common practice when
uploading a WIP patch, as a signal that 'I have no intention of landing
this patch', and as a courtesy so a reviewer will not waste any time
looking at it (unless specifically asked).

I don't see why I wouldn't be allowed to r- my own patch?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121116/2e012f0e/attachment.html>

More information about the webkit-dev mailing list