[webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?

[Žan Doberšek]

On Tue, Nov 13, 2012 at 8:59 PM, Raphael Kubo da Costa <rakuco at webkit.org>wrote:

> Dirk Pranke <dpranke at chromium.org> writes:
>
> > So, it seems like WK1 and WK2 keywords might be useful. However, I
> > don't really want to add more divergence between ports, so it would be
> > nice to have everyone agree to use it if we were to add it.
> >
> > What do you all think? Would you like this feature, and would you all
> > use it ?
>
> At least on the EFL side I think things are good the way they are: we
> have platform/efl for common stuff and platform/efl-wk1 and
> platform/efl-wk2 for WK1- or WK2-specific stuff (not only
> TestExpectations files but also test results). If we got rid of those
> and put everything together in platform/efl, I think we'd end up with a
> very big TestExpectations file and don't know what we'd do with the
> occasional different results for WK1 and WK2.
>

I'm pushing for the same hierarchy for the GTK port in
https://bugs.webkit.org/show_bug.cgi?id=97562
I also agree that keeping all expectations in one TestExpectations file and
using WK1/WK2 modifiers would bloat that file and considerably affect
efficient work with it.

Personally, I don't have any need for these additional modifiers, I'd
rather see wk1- and wk2-specific fallback directories with their own
TestExpectations. While not strictly related to this, I'd also like someday
see Chromium port moving to a similar organisation of their baselines, in
place of using many platform modifiers which could then be removed.

-Z


>
> > However, this is a little awkward and gets worse if you also need to
> > support different expectations for multiple different configs (e.g.,
> > mac-lion vs mac-snowleopard vs mac-mountainlion).
>
> It wouldn't really solve this problem, right?
>
> --
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121114/433cd2bf/attachment.html>