[webkit-dev] sharing more test references

Tue Nov 13 17:06:51 PST 2012

<!DOCTYPE html>
<body style="margin: 0px">
<div style="height: 100px; width: 100px; background-color: green">

Does seem pretty simple.

<!DOCTYPE html>
<body style="margin: 0px">
<svg><rect width="100px" height="100px" fill="green"><svg>

is even shorter. :)

I support getting rid of pixel tests.  I suspect that some very dumb
scripts could turn large chunks of these existing pixel-tests into
ref-tests.  I doubt that those would be the interesting ones though
(where platforms have divergent results).

On Tue, Nov 13, 2012 at 4:59 PM, Darin Adler <darin at apple.com> wrote:
> On Nov 13, 2012, at 4:56 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>
>> Wouldn't the fact that there are a large set of tests with the same result be an argument *for* doing the iframe thing?
>
> The simple hand-coded green square in upper left corner should be simple, perhaps even simpler than the iframe thing.
>
>> What is the advantage to having 50 copies of a hand-coded "green square in upper left corner" reference test?
>
> Tests standing alone and being independent, easy to move around, revise, and understand individually rather than as part of a suite.
>
> I don’t have a strong objection to your iframe technique, but I’d start simpler and do it only if it’s really needed.
>
> -- Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev