[webkit-dev] sharing more test references
dpranke at chromium.org
Tue Nov 13 16:56:44 PST 2012
On Tue, Nov 13, 2012 at 4:33 PM, Darin Adler <darin at apple.com> wrote:
> On Nov 13, 2012, at 4:01 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>> It turns out that we have a reasonably large number of tests that produce the exact same pixel results. On chromium-mac on 10.8, for example, there are 2048 tests that share a result with some other test. 50 of them, for example, draw a green square in the upper left corner of the page (e.g., for svg/custom/root-element.html).
> It seems to me that when we find a pattern like this, we should create a hand-coded reference test result. The fact that so many tests produce the same pixels means that each reference can be used to move a lot of tests from the pixel test to the reference test category.
> I don’t think we need to do that <iframe> thing you said, as long as there are large sets of tests with the same result, since if the payoff for each reference is big enough, it should be affordable to hand-write the reference file.
I don't think I'm understanding you. Wouldn't the fact that there are
a large set of tests with the same result be an argument *for* doing
the iframe thing? What is the advantage to having 50 copies of a
hand-coded "green square in upper left corner" reference test?
More information about the webkit-dev