[webkit-dev] Settings::devicePixelRatio and Settings::defaultDeviceScaleFactor

[James Robinson]

(top-posting to fit in)

Doesn't the same argument apply to *deviceScaleFactor?  That doesn't make
sense as a Setting either.

Pushing one or both out of settings doesn't answer the question of whether
they are redundant.  My gut feeling is that they are and we should fold
them together.  Alternately, delete defaultDeviceScaleFactor completely.

- James

On Thu, May 31, 2012 at 3:50 PM, Simon Fraser <simon.fraser at apple.com>wrote:

> I don' t think devicePixelRatio() belongs in settings. It should be either
> be obtained from the platform code in WebCore/WebKit, or pushed in via API.
>
> Simon
>
> On May 31, 2012, at 3:48 PM, Adam Barth wrote:
>
> > Is there any difference between Settings::devicePixelRatio [1] and
> > Settings::defaultDeviceScaleFactor [2] ?  They appear to be used by
> > disjoint sets of ports.  Shall we delete one in favor of the other?
> >
> > Adam
> >
> > [1]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L478
> > [2]
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.h#L106
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120531/5049f8fa/attachment.html>