[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)
ojan at chromium.org
Thu May 17 14:11:48 PDT 2012
On Thu, May 17, 2012 at 2:06 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Thu, May 17, 2012 at 2:05 PM, Ojan Vafai <ojan at chromium.org> wrote:
>> On Thu, May 17, 2012 at 2:02 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>> Seems reasonable as the first step except:
>>> On Thu, May 17, 2012 at 1:34 PM, Ojan Vafai <ojan at chromium.org> wrote:
>>>> 6. Use the same character as a separator before and after the test
>>> I counter-propose to drop ":" or any other delimiter altogether.
>>> Delimiters are the biggest pain points in the current syntax as suggested
>>> by Benjanmin, Darin, and I.
>>> If we're going to have expectations after test name, then there's no
>>> need for delimiters other than imposing arbitrary maintenance cost on
>>> everyone who edits the file.
>> There is clearly not consensus on this. Getting rid of "=" as a delimiter
>> seemed uncontroversial to me. Note that I explicitly put getting rid of
>> delimiters in the controversial list.
> Who opposed this? And why is he or she not replying on this thread?
Oh, I supposed I misread Peter's earlier email as being opposed to this.
But, I for one am opposed to it. I find the jumble of modifiers in the
second set of lines here much harder to quickly parse than the groupings in
the first set of lines.
webkit.org/b/12345 : foo/bar.html
MAC DEBUG : foo/bar.html : SLOW
crbug.com/1234 : foo/bar.html : SLOW TEXT IMAGE
MAC DEBUG foo/bar.html SLOW
crbug.com/1234 foo/bar.html SLOW TEXT IMAGE
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev