[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Ryosuke Niwa rniwa at webkit.org
Thu May 17 12:47:50 PDT 2012

On Thu, May 17, 2012 at 12:36 PM, Dirk Pranke <dpranke at chromium.org> wrote:

>  On Thu, May 17, 2012 at 4:30 AM, Ojan Vafai <ojan at chromium.org> wrote:
> > -Make everything but the test name case-insensitive.
> I don't think I like this; it could lead to a lot of arbitrarily
> different formatting in the file, making things harder to read.

Modifiers and expectations are already case-insensitive as far as I read
the code yesterday.

I think we'd probably find ourselves (re-)converging on some convention
> pretty quickly. I personally find all uppercase fairly easy to read in
> this case since it distinguishes the modifiers from the test name.

I think this problem will disappear once we place modifiers and
expectations on the same side
because then there is exactly one place those tokens could appear. There is
no need to scan
through a line then.

> If we have some other clear delimiter this would probably be less
> important, in which case all lower case would be fine as well. Initial caps
> seems less good to me.

I find either all-lowercase or all-caps to be much harder to read than
capitalized words. They look like a blob of letters to me. Also, I don't
think we use all-caps name anywhere else in WebKit so it's inconsistent
with the convention we use elsewhere.

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120517/b1c6abac/attachment.html>

More information about the webkit-dev mailing list