[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Thu May 17 11:54:25 PDT 2012

On May 17, 2012, at 11:28 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Thu, May 17, 2012 at 11:08 AM, Peter Kasting <pkasting at google.com> wrote:
> On Thu, May 17, 2012 at 9:26 AM, Dimitri Glazkov <dglazkov at chromium.org> wrote:
> I actually quite like
> the clear delineation between test modifiers and test expectations.
> 
> Me too.  Please please please leave them on opposite sides.  All these proposals that try to put them both before the test name are much harder for me to understand.  Even dropping the all-caps format for keywords is a loss for me as this differentiation makes it easier for me to scan the line and distinguish the three important pieces of a line: what, where, and how.  
> 
> I find most of the changes that have been proposed so far to be a significant decrease in clarity, except for the idea to change BUGXX### into links (for all bug trackers, not just non-WebKit ones), which I think would be fine; and the idea of moving SLOW, SKIP, and WONTFIX from the left side to the right, as these seem more like "expectations about how the test will run" than "platforms on which the test fails".
> 
> Interesting. I find the new format (I've replaced [] by () since that worked better for me) much easier to read than the old format because now all meta data is in one place. For me, I'm most annoyed by the unreasonably long bug URLs in the new format. Maybe putting the URL isn't such a great idea after all :( 

Perhaps aligning the fields column after the bug URL would improve readability (though it makes things a little harder to edit):

crbug.com/24182    Slow (Mac Debug)       fast/css/large-list-of-rules-crash.html
crbug.com/24182    Slow (Linux Mac Debug) fast/dom/Window/window-postmessage-clone-really-deep-array.html
crbug.com/24182    Slow (Mac Debug)       fast/forms/select-set-length-with-mutation-remove.html
crbug.com/24182    Slow (All)             fast/js/regexp-overflow.html
crbug.com/24182    Slow (Debug)           fast/js/toString-and-valueOf-override.html
crbug.com/24182    Slow (Debug)           html5lib/webkit-resumer.html
crbug.com/24182    Slow (Win Release)     http/tests/loading/onload-vs-immediate-refresh.pl
crbug.com/79910    Image (SnowLeopard)    fast/text/international/bidi-linebreak-001.html
crbug.com/79910    Image (SnowLeopard)    fast/text/international/bidi-linebreak-002.html
crbug.com/79910    Image (SnowLeopard)    fast/text/international/bidi-linebreak-003.html
webkit.org/b/58924 Pass Timeout (Mac)     plugins/mouse-click-iframe-to-plugin.html
webkit.org/b/60099 Pass Crash (Debug)     fast/dom/Attr/access-after-element-destruction.html
webkit.org/b/60097 Pass Text (Debug)      fast/dom/HTMLLinkElement/link-and-subresource-test.html

I would also suggest omitting (All), particularly if it turns out to be the common case.

Regards,
Maciej

> 
> crbug.com/24182 Slow (Mac Debug) fast/css/large-list-of-rules-crash.html
> crbug.com/24182 Slow (Linux Mac Debug) fast/dom/Window/window-postmessage-clone-really-deep-array.html
> crbug.com/24182 Slow (Mac Debug) fast/forms/select-set-length-with-mutation-remove.html
> crbug.com/24182 Slow (All) fast/js/regexp-overflow.html
> crbug.com/24182 Slow (Debug) fast/js/toString-and-valueOf-override.html
> crbug.com/24182 Slow (Debug) html5lib/webkit-resumer.html
> crbug.com/24182 Slow (Win Release) http/tests/loading/onload-vs-immediate-refresh.pl
> 
> crbug.com/79910 Image (SnowLeopard) fast/text/international/bidi-linebreak-001.html
> crbug.com/79910 Image (SnowLeopard) fast/text/international/bidi-linebreak-002.html
> crbug.com/79910 Image (SnowLeopard) fast/text/international/bidi-linebreak-003.html
> 
> webkit.org/b/58924 Pass Timeout (Mac) plugins/mouse-click-iframe-to-plugin.html
> 
> webkit.org/b/60099 Pass Crash (Debug) fast/dom/Attr/access-after-element-destruction.html
> webkit.org/b/60097 Pass Text (Debug) fast/dom/HTMLLinkElement/link-and-subresource-test.html
> 
> 
> BUGCR24182 SLOW MAC DEBUG : fast/css/large-list-of-rules-crash.html = PASS
> BUGCR24182 SLOW LINUX MAC DEBUG : fast/dom/Window/window-postmessage-clone-really-deep-array.html = PASS
> BUGCR24182 SLOW MAC DEBUG : fast/forms/select-set-length-with-mutation-remove.html = PASS
> BUGCR24182 SLOW : fast/js/regexp-overflow.html = PASS
> BUGCR24182 SLOW DEBUG : fast/js/toString-and-valueOf-override.html = PASS
> BUGCR24182 SLOW DEBUG : html5lib/webkit-resumer.html = PASS
> BUGCR24182 SLOW WIN RELEASE : http/tests/loading/onload-vs-immediate-refresh.pl = PASS
> 
> BUGCR79910 SNOWLEOPARD : fast/text/international/bidi-linebreak-001.html = IMAGE
> BUGCR79910 SNOWLEOPARD : fast/text/international/bidi-linebreak-002.html = IMAGE
> BUGCR79910 SNOWLEOPARD : fast/text/international/bidi-linebreak-003.html = IMAGE
> 
> BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = PASS TIMEOUT
> 
> BUGWK60099 DEBUG : fast/dom/Attr/access-after-element-destruction.html = PASS CRASH
> BUGWK60097 DEBUG : fast/dom/HTMLLinkElement/link-and-subresource-test.html = PASS TEXT
> 
>  
> 
> 
> PK
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120517/55590e05/attachment.html>