[webkit-dev] please add EditBugs permission

[Eric Seidel]

You have to have EditUser permission to run that script.  It should
bail out with a nicer message when you dont. :(

% Tools/Scripts/webkit-patch add-users-to-groups epoger at chromium.org
Add users matching "epoger at chromium.org" which groups?
 1. canconfirm
 2. editbugs
Enter one or more numbers (comma-separated), or "all":
Reading Keychain for bugs.webkit.org account and password.  Click
"Allow" to continue...
Logging in as eric at webkit.org...
Found 1 users matching epoger at chromium.org:
epoger at chromium.org (18143)
Are you sure you want add 1 users to groups ['canconfirm',
'editbugs']?  (This action cannot be undone using webkit-patch.)
[Y/n]:
Adding epoger at chromium.org to ['canconfirm', 'editbugs']

Done.

On Tue, May 15, 2012 at 1:33 PM, Elliot Poger <epoger at chromium.org> wrote:
> Can someone please add EditBugs permission for my bugs.webkit.org account
> (epoger at chromium.org)?
>
> Another WebKit committer and I both tried it, using the steps Eric pasted in
> April, but it failed... I think maybe the add-users-to-groups tool is
> broken?
>
> $ Tools/Scripts/webkit-patch add-users-to-groups epoger at chromium.org
> Add users matching "epoger at chromium.org" which groups?
>  1. canconfirm
>  2. editbugs
> Enter one or more numbers (comma-separated), or "all": all
> bugs.webkit.org login: epoger at google.com
> bugs.webkit.org password for epoger at google.com:
> Logging in as epoger at google.com...
> Traceback (most recent call last):
>   File "Tools/Scripts/webkit-patch", line 69, in <module>
>     main()
>   File "Tools/Scripts/webkit-patch", line 64, in main
>     WebKitPatch(os.path.abspath(__file__)).main()
>   File
> "/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py",
> line 311, in main
>     result = command.check_arguments_and_execute(options, args, self)
>   File
> "/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py",
> line 120, in check_arguments_and_execute
>     return self.execute(options, args, tool) or 0
>   File
> "/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py",
> line 50, in execute
>     login_userid_pairs =
> tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
>   File
> "/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py",
> line 257, in fetch_login_userid_pairs_matching_substring
>     return
> EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
>   File
> "/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py",
> line 72, in login_userid_pairs_from_edit_user_results
>     login_userid_pairs = [self._login_and_uid_from_row(row) for row in
> results_table('tr')]
> TypeError: 'NoneType' object is not callable
>
>
> On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel <eric at webkit.org> wrote:
>>
>> Done.
>>
>> % webkit-patch add-users-to-groups shezbaig.wk at gmail.com
>> Add users matching "shezbaig.wk at gmail.com" which groups?
>>  1. canconfirm
>>  2. editbugs
>> Enter one or more numbers (comma-separated), or "all":
>> Reading Keychain for bugs.webkit.org account and password.  Click
>> "Allow" to continue...
>> Logging in as eric at webkit.org...
>> Found 1 users matching shezbaig.wk at gmail.com:
>> shezbaig.wk at gmail.com (17597)
>> Are you sure you want add 1 users to groups ['canconfirm',
>> 'editbugs']?  (This action cannot be undone using webkit-patch.)
>> [Y/n]:
>> Adding shezbaig.wk at gmail.com to ['canconfirm', 'editbugs']
>>
>> On Thu, Apr 12, 2012 at 3:17 PM, Shezan Baig <shezbaig.wk at gmail.com>
>> wrote:
>> > Hello,
>> >
>> > When I submit a patch to bugzilla, I get an error that EditBugs is not
>> > set
>> > on my account.  Can someone add this permission to my bugzilla account
>> > please?  I sent a message to <webkit-committers at lists.webkit.org> as
>> > instructed, but that doesn't get through.
>> >
>> > My login is: shezbaig.wk at gmail.com
>> > My patch submitted to: https://bugs.webkit.org/show_bug.cgi?id=80382
>> >
>> > Thanks,
>> > Shezan
>> >
>> >
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>