[webkit-dev] Feature Announcement: Adding <iframe seamless>

Maciej Stachowiak mjs at apple.com
Wed May 2 13:39:10 PDT 2012


On May 2, 2012, at 1:03 PM, Adam Barth <abarth at webkit.org> wrote:

> One example from this case is seamless navigation.  I implemented
> seamless navigation in two steps:
> 
> 1) Refactoring the existing codepaths to go through a common function.
> 2) Teaching the common function how to redirect navigation for
> seamless iframes (e.g., hyperlinks inside a seamless iframe navigate
> the parent frame).
> 
> Step (1) is hard to protect with ifdefs whereas step (2) is easy.
> Fortunately, in this specific case, we landed step (1) a while ago, so
> it's had some time to bake already.

In this specific example, it seems reasonable to ifdef only the work of step (2), particularly since, as you note, step (1) has already landed.

Regards,
Maciej



More information about the webkit-dev mailing list