[webkit-dev] Reg: DRT output for border properties

[M Rahaman]

Hi All,

 

I have created https://bugs.webkit.org/show_bug.cgi?id=82821 for the problem
mentioned here. I would like to hear any comments people might have who
knows the related area better than me, so that I can propose the patch, as
it might require considerable re-baselining.

 

Regs,

Rahaman

 

From: webkit-dev-bounces at lists.webkit.org
[mailto:webkit-dev-bounces at lists.webkit.org] On Behalf Of M Rahaman
Sent: Friday, March 30, 2012 10:22 PM
To: webkit-dev at lists.webkit.org
Subject: [webkit-dev] Reg: DRT output for border properties

 

Hi All,

 

Recently I have made an observation regarding the DRT output for border
properties for various html element e.g. consider the following

RenderTableCell {TD} at (2,2) size 30 [border: none (2px solid #0000FF)
none]

Please note that the border properties are printed 

.         In the order of Top, Right, Bottom & Left

.         Also, if two consecutive properties are same, they are printed
once => if my right.border==bottom.border, either of right/bottom are
printed e.g. [border: (Top-border-properties), (Right-border-properties),(
Left-border-properties)] & if no border is drawn, it is shown as none (in
WebCore/rendering/RenderTreeAsText.cpp)

 

So if we consider the below table,



 

	
DRT o/p

Top 

Right

Bottom

Left


#1

none (2px solid #0000FF) none

none

none

(2px solid #0000FF)

none

		
none

(2px solid #0000FF)

none

none

		
none 

(2px solid #0000FF)

(2px solid #0000FF)

none

						

#2

none (2px solid #0000FF)

none

none

none

(2px solid #0000FF)

		
none

none

(2px solid #0000FF)

(2px solid #0000FF)

		
none

(2px solid #0000FF)

(2px solid #0000FF)

(2px solid #0000FF)

 

 

 

 

 

 


 

 

 

 

 

 

 

 


It basically shows that one DRT o/p does not convey enough information about
the various border properties.

1.       My question: Is this observation correct or if I am missing
anything here?

2.       And if the above understanding is correct, then I propose that we
only print those border info that are being drawn (with addition info like
which border) & don't print "none" at all, so that it is easier to interpret
the info.

 

Any suggestion is always welcome J

Regs,

Rahaman

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 

 

 

 


 

 

 

 

 

 

 

 


 

 

 

 

 

 

 

 


 

 

 

 

 

 

 

 


 

 

 

 

 

 

 

 


 

 

 

 

 

 

 

 

	

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 


 

 

 

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120331/849439c3/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DRT_Output_Border.xls
Type: application/vnd.ms-excel
Size: 33280 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120331/849439c3/attachment-0001.xls>