[webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

The move appears to be a success.

Mac, CrMac, CrWin, CrLinux, Gtk and Qt are all back building again.

Win, CrAndroid and EFL are in progress.

HUGE thank you to Mark Rowe, Tony Chang, Jessie Berlin, Martin
Robinson, Csaba Osztrogonac, Carlos Garcia Campos, Michael Saboff, and
Filip Pizlo for all their help with their respective platforms!

If I can be of further help, let me know.

-eric

On Thu, Mar 22, 2012 at 3:50 PM, Eric Seidel <eric at webkit.org> wrote:
> Going ahead with the land now.
>
> Will be around for several hours fixing builds.  I'm sorry for any breaks.
>
> -eric
>
> On Wed, Mar 21, 2012 at 7:08 PM, Eric Seidel <eric at webkit.org> wrote:
>> I've posted my first-draft patch to:
>> https://bugs.webkit.org/show_bug.cgi?id=81844
>>
>> If port maintainers would like to apply it locally and upload improved
>> versions (or upload diffs on top of that version) that would be most
>> welcome.
>>
>>
>> svn-apply seems to be having trouble with the "adds" for the WTF
>> files, thus causing all the EWS bots to fail.
>>
>> I'm also working on getting a git branch (on github) of my changes, to
>> make it easier for port maintainers to send me updates (instead of
>> passing around 5MB diffs).
>>
>>
>> At this point it may be best to just land the change tomorrow and fix
>> all the buildbots after the fact.  We should be very close, with all
>> the header work which has been done over the last month.
>>
>> -eric
>>
>> On Tue, Mar 20, 2012 at 5:18 PM, Eric Seidel <eric at webkit.org> wrote:
>>> We're ready to complete the move.
>>>
>>> https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
>>> evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h
>>>
>>> Tomorrow (Weds) I will move a .cpp file in the same way.
>>>
>>> Thursday, I will move all the rest of the WTF files.  I will also
>>> update svn-apply so that in-flight patches should transparently patch
>>> the right files post-move.
>>>
>>> Let me know if you have questions or concerns.
>>>
>>> -eric
>>>
>>> On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel <eric at webkit.org> wrote:
>>>> I'm going to push off the move, probably until next week.
>>>>
>>>> Thank you for the Qt patch!
>>>>
>>>> I'll post a patch for Mark and we can discuss further from there.
>>>>
>>>> -eric
>>>>
>>>> On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba <oszi at inf.u-szeged.hu> wrote:
>>>>> Hi,
>>>>>
>>>>> I uploaded the necessary buildfix for Qt to the bugzilla:
>>>>> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>>>>
>>>>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>>>>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>>>>
>>>>> I made it locally to be able prepare the Qt buildfix and I had to replace
>>>>> all
>>>>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>>>>> The patch is huge, ~2Mb and ~4000 files are affected.
>>>>>
>>>>> I suggest landing the following patches separately:
>>>>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>>>>> - s/wtf/WTF/g patch :)
>>>>> - platform buildfixes
>>>>>
>>>>> Please let me know if you have the new date for landing these patches. I
>>>>> would be happier with a more CET timezone friendly timing. - 08:00-00:00 in
>>>>> CET.
>>>>>
>>>>> br,
>>>>> Ossy
>>>>>
>>>>> Eric Seidel írta:
>>>>>
>>>>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>>>>> time.  We believe we're nearly there.
>>>>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>>>>>
>>>>>> This will mean that WTF will be built as a separate static library on all
>>>>>> ports.
>>>>>>
>>>>>> The plan is to do this move all in one piece, after work hours PST,
>>>>>> when the tree is least active.
>>>>>>
>>>>>> It won't be the most beautiful transition (as we're likely to break at
>>>>>> least one port in the process), but we'll try not to make too much of
>>>>>> a mess.
>>>>>>
>>>>>> We believe all the ports are ready for the move, except AppleWin:
>>>>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>>>>>
>>>>>> Once AppleWin is ready we'll schedule a date for the transition and
>>>>>> announce it one this thread.
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> -eric