[webkit-dev] ChangeLogs

Adam Barth abarth at webkit.org
Wed Mar 21 14:46:04 PDT 2012


On Wed, Mar 21, 2012 at 2:29 PM, Timothy Hatcher <timothy at apple.com> wrote:
> Lately I have observed more and more and more changes going into WebKit that
> lack any details about why a particular change was made. It is intended that
> the ChangeLog (and commit message) contain some details about your change,
> not just the bug title and URL.

Since I was the reviewer for <http://trac.webkit.org/changeset/111577>
(although if you look in the bug thread, you'll see that I was just
forwarding fishd's R+ after some trivial cleanups), I'm curious what
additional information you think should have been included in that
ChangeLog.

There really isn't much to say about that change.  Tommy was just
adding thin API wrappers around WebCore objects as part of the
implementation of the MediaStream API.  The main point of discussion
in the bug thread was whether to use the name ICE or Ice.

Adam


More information about the webkit-dev mailing list