[webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)
jianli at chromium.org
Tue Mar 13 13:38:04 PDT 2012
What will NOTIFICATIONS cover after LEGACY_NOTIFICATIONS is being added?
Does it cover new syntax only or any syntax that are not considered old?
On Tue, Mar 13, 2012 at 1:29 PM, Jon Lee <jonlee at apple.com> wrote:
> LEGACY_NOTIFICATIONS, for the most part, is exactly what NOTIFICATIONS
> covers now. So yes, it includes HTML notifications and old syntax, and will
> not remove anything that already exists.
> On Mar 13, 2012, at 1:25 PM, Jian Li <jianli at chromium.org> wrote:
> Jon, could you please provide what are going to be included in
> LEGACY_NOTIFICATIONS? Does LEGACY_NOTIFICATION only includes HTML
> notification and old syntax we're considering to deprecate?
> On Mon, Mar 12, 2012 at 7:11 PM, Adam Barth <abarth at webkit.org> wrote:
>> That sounds like a good approach. Chromium will likely need to
>> remember to disable NOTIFICATIONS on any upcoming release branches
>> (until the work is complete).
>> On Mon, Mar 12, 2012 at 6:58 PM, Jon Lee <jonlee at apple.com> wrote:
>> > Hi WebKit!
>> > In order to ease the migration path for the nascent notifications API,
>> I'd like to separate the current dependency between NOTIFICATION and
>> LEGACY_NOTIFICATIONS. Currently, in order to support the legacy API, both
>> defines are needed, but ends up also including the new API.
>> > Since the future is to eventually move to the spec'd API, I like to
>> separate the two defines, so that NOTIFICATIONS covers the new API, and
>> LEGACY_NOTIFICATIONS the previous one. Currently all ports that support
>> notifications will support both.
>> > <https://bugs.webkit.org/show_bug.cgi?id=80922> tracks the work, and
>> once the patch lands,
>> > ports that wish to avoid exposing the new API should remove the
>> NOTIFICATION define.
>> > Any concerns?
>> > Thanks,
>> > Jon
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev