[webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

[Adam Barth]

That sounds like a good approach.  Chromium will likely need to
remember to disable NOTIFICATIONS on any upcoming release branches
(until the work is complete).

Adam


On Mon, Mar 12, 2012 at 6:58 PM, Jon Lee <jonlee at apple.com> wrote:
> Hi WebKit!
>
> In order to ease the migration path for the nascent notifications API, I'd like to separate the current dependency between NOTIFICATION and LEGACY_NOTIFICATIONS. Currently, in order to support the legacy API, both defines are needed, but ends up also including the new API.
>
> Since the future is to eventually move to the spec'd API, I like to separate the two defines, so that NOTIFICATIONS covers the new API, and LEGACY_NOTIFICATIONS the previous one. Currently all ports that support notifications will support both.
>
> <https://bugs.webkit.org/show_bug.cgi?id=80922> tracks the work, and once the patch lands,
> ports that wish to avoid exposing the new API should remove the NOTIFICATION define.
>
> Any concerns?
>
> Thanks,
> Jon
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev