[webkit-dev] Please set the svn:mime-type property on binary files before committing

[Ashod Nakashian]

Please let's also enforce svn:eol-style to LF for all scripts as this is breaking (at least) the bash scripts that are checked-out with native style on Windows. Some bash versions don't like CR. Please see a (failed) attempt at fixing this manually[1].

I also believe we should mark all (Bash/Perl/Python) scripts as executable. It's best to at least automate it, if not also check for violations via check-webkit-style. (And for the loving of all that's good, would someone please help with this bug[1]?)

[1] https://bugs.webkit.org/show_bug.cgi?id=79509

-Ash




>________________________________
> From: Simon Fraser <simon.fraser at apple.com>
>To: Eric Seidel <eric at webkit.org> 
>Cc: WebKit Development <webkit-dev at lists.webkit.org> 
>Sent: Thursday, March 8, 2012 3:37 AM
>Subject: Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing
> 
>The best way to enforce it would be with a pre-commit hook:
><https://bugs.webkit.org/show_bug.cgi?id=80548>
>
>Simon
>
>On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote:
>
>> Unless this is enforced by a tool, it's very likely to be forgotten.
>> 
>> https://bugs.webkit.org/show_bug.cgi?id=75824
>> https://bugs.webkit.org/show_bug.cgi?id=75825
>> 
>> 
>> On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein <mitz at apple.com> wrote:
>>> Please set the svn:mime-type property on binary files that you add to the
>>> tree, such as *-expected.png, before committing. Otherwise the resulting
>>> webkit-changes message will include those files as text, which is
>>> inconvenient.
>>> 
>>> Thanks.
>>> 
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>_______________________________________________
>webkit-dev mailing list
>webkit-dev at lists.webkit.org
>http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120308/2b17c0c2/attachment.html>