[webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

[Alexey Proskuryakov]

02.03.2012, в 15:10, Adam Barth написал(а):

>> For example, I think that <https://bugs.webkit.org/show_bug.cgi?id=80193> that moves some knowledge of what makes a page uncacheable out of PageCache::canCachePageContainingThisFrame makes the code less hackable, and is likely to become a disadvantage.
> 
> I've just started investigating that issue (which is why the patch is
> labeled "work-in-progress").  

That's understood. Do you find it inappropriate to make comments about patches in Bugzilla that are work in progress?

> Is there a reason SQLDatabase is special
> cased in PageCache?  Most features interact with the PageCache via
> ActiveDOMObject::canSuspend().  In that bug, I'm investigating why
> SQLDatabase doesn't just use the same general mechanism as other
> features.

It's difficult to make something an ActiveDOMObjects without introducing subtle bugs. The automatic invocation of suspend/resume functions it provides comes at the cost of unpredictable order they are invoked in, and of very strict limitations on what these functions can do.

- WBR, Alexey Proskuryakov