[webkit-dev] [PATCH] Errors from "build-webkit --debug --minimal"

[Patrick Gansterer]

IMHO only setting up a bot won't help that much. Someone must keep it green. From my experience with the WinCE build slave (which has some common features turned of by default) I don't see many people caring about it.
E.g. WinCE build slaves builds with JIT turned of, which leads to much redness of the bot. IMHO that's ok, since the bots exist to find failures with other configurations (even if EWS does much work in that area already), but most of the redness of the WinCE bot stays until I have the time to fix it [1]. BTW: It's not that much fun to fix all failures (and find the corresponding revision) if you pause for a few weeks.
Do we have any defined responsibility, when someone breaks a port? Should the committer watch landing of the patch? (and ping the port maintainers if it has some port specific issues) Can we make the green/red status more meaningful, to make it easier to see if a patch cases real problems? (IMHO many bots are red by default this time and so don't provide quick information in the buildbot overview pages)

-- Patrick

[1] http://trac.webkit.org/search?q=paroga+ENABLE%28JIT%29

Am 25.06.2012 um 21:56 schrieb Eric Seidel:

> If someone wanted to set up a --minimal bot, I'm sure that would be
> welcome.  We used to have a --qt --minimal bot at some point.
> 
> http://trac.webkit.org/wiki/BuildBot
> 
> On Mon, Jun 25, 2012 at 12:28 PM, Pablo Flouret <pablof at motorola.com> wrote:
>> On Mon, 25 Jun 2012 12:03:12 -0700, Arthur O'Dwyer <arthur at push.am> wrote:
>> 
>>> I'm trying to build WebKit by the simplest possible method. I checked
>>> out the SVN tree and did "cd WebKit ; Tools/Scripts/build-webkit
>>> --debug --minimal". This produced compiler errors!
>> 
>> 
>> I tried the same thing a while ago, and submitted patches to fix some of the
>> issues, but what i was told is that there aren't really any bots building
>> with --minimal, so it's not guaranteed to build.
>> 
>> Last i remember, after you fix those issues you mention you're probably
>> gonna come up against trickier ones in --web-audio, --geolocation,
>> --netscape-plugin-api and --fullscreen-api (although i haven't checked
>> recently).
>> 
>> You can still run --minimal and enable the features that are giving you
>> trouble (e.g. build-webkit --debug --minimal --javascript-debugger
>> --geolocation ... etc.)
>> 
>> Cheers,
>> 
>> --
>> pablo flouret
>> motorola | webkit / browser team
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev