[webkit-dev] [PATCH] Errors from "build-webkit --debug --minimal"

[Arthur O'Dwyer]

I'm trying to build WebKit by the simplest possible method. I checked
out the SVN tree and did "cd WebKit ; Tools/Scripts/build-webkit
--debug --minimal". This produced compiler errors!

The first two errors were easy to fix; it was just a case of features
being incompletely #ifdef'ed. I've quoted the patch at the bottom of
this message, since I'm not sure yet if this mailing list accepts
attachments.


This next error, related to ENABLE(JAVASCRIPT_DEBUGGER), I can't
figure out how to fix. So I'm passing "build-webkit --debug --minimal
--javascript-debugger" as a workaround.

/Users/ajo/Desktop/WebKit/Source/WebCore/bindings/js/JSConsoleCustom.cpp:41:20:
error: out-of-line definition of 'profile' does not match any
declaration in 'WebCore::JSConsole'
JSValue JSConsole::profile(ExecState* exec)
                   ^~~~~~~
/Users/ajo/Desktop/WebKit/Source/WebCore/bindings/js/JSConsoleCustom.cpp:52:20:
error: out-of-line definition of 'profileEnd' does not match any
declaration in 'WebCore::JSConsole'
JSValue JSConsole::profileEnd(ExecState* exec)
                   ^~~~~~~~~~
2 errors generated.


Then I get this fourth error, many many times. There's no
--dashboard-support option to build-webkit, so I'm stumped.

perl -I WebCore/bindings/scripts/
WebCore/bindings/scripts/generate-bindings.pl --include WebCore/dom
--include WebCore/fileapi --include WebCore/html --include WebCore/css
--include WebCore/page --include WebCore/notifications --include
WebCore/xml --include WebCore/svg --write-dependencies --outputDir .
--defines "               ENABLE_DASHBOARD_SUPPORT
   ENABLE_JAVASCRIPT_DEBUGGER ENABLE_LEGACY_CSS_VENDOR_PREFIXES
                ENABLE_TEXT_NOTIFICATIONS_ONLY      ENABLE_WEB_AUDIO
   LANGUAGE_OBJECTIVE_C" --generator ObjC --supplementalDependencyFile
./SupplementalDependencies.txt WebCore/html/ImageData.idl
In file included from <built-in>:151:
<command line>:1:9In file included from <built-in>:151:
#define -DENABLE_DASHBOARD_SUPPORT 1
        ^
: error: macro names must be identifiers

Any helpful ideas?
-Arthur

Here is the patch for the first two errors:

$ svn diff
Index: Source/WebCore/inspector/InspectorResourceAgent.cpp
===================================================================
--- Source/WebCore/inspector/InspectorResourceAgent.cpp	(revision 121171)
+++ Source/WebCore/inspector/InspectorResourceAgent.cpp	(working copy)
@@ -64,7 +64,9 @@
 #include "WebSocketHandshakeResponse.h"

 #include <wtf/CurrentTime.h>
+#if ENABLE(WEB_SOCKETS)
 #include <wtf/HexNumber.h>
+#endif
 #include <wtf/ListHashSet.h>
 #include <wtf/RefPtr.h>
 #include <wtf/text/StringBuilder.h>
Index: Source/WebCore/css/CSSPropertyNames.in
===================================================================
--- Source/WebCore/css/CSSPropertyNames.in	(revision 121171)
+++ Source/WebCore/css/CSSPropertyNames.in	(working copy)
@@ -332,7 +332,9 @@
 -webkit-min-logical-width
 -webkit-min-logical-height
 -webkit-nbsp-mode
+#if defined(ENABLE_CSS3_FLEXBOX) && ENABLE_CSS3_FLEXBOX
 -webkit-order
+#endif
 -webkit-padding-after
 -webkit-padding-before
 -webkit-padding-end

$ svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 121171
Node Kind: directory
Schedule: normal
Last Changed Author: jonlee at apple.com
Last Changed Rev: 121171
Last Changed Date: 2012-06-25 11:05:13 -0700 (Mon, 25 Jun 2012)