[webkit-dev] Use testRunner instead of layoutTestController in new regression tests (a.k.a. layout tests)

Ryosuke Niwa rniwa at webkit.org
Mon Jun 18 23:48:14 PDT 2012

Hello WebKittens,

I've exposed layoutTestController as testRunner in
http://trac.webkit.org/changeset/119946. Moving forward, please use
window.testRunner (as supposed to window.layoutTestController) in new tests
you write.

If you're interested in helping the effort to update existing tests to use
testRunner instead of layoutTestController, run variants of the following
shell command:

find LayoutTests/fast/css LayoutTests/platform/*/fast/css -type f -not
-wholename '*/.svn/*' -print0 \
    | xargs -0 grep -nHl layoutTestController \
    | xargs sed -i "" -e "s/layoutTestController/testRunner/g"

then revert all new line changes. While sed adds a new line at the end of
each file when one is missing, this causes documents in quirks mode to
render differently and thus the modified tests to fail.

Upload the patch and cc me.

Ryosuke Niwa
Software Engineer
Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120618/2ed74799/attachment.html>

More information about the webkit-dev mailing list