[webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

Ryosuke Niwa rniwa at webkit.org
Fri Jun 15 12:22:30 PDT 2012

On Fri, Jun 15, 2012 at 12:14 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> I am not sure how to get the key points across without being accurate or
> misleading. A version that I think explains the complete design without
> saying anything false or misleading:
> refTheDocumentItselfButUnlikeTheRegularRefDontPreventTheDocumentsChildrenFromBeingRemovedToAvoidCyclesWhenRefingTheOwnerDocument
> To make a reasonable name we probably need to focus on one of these
> aspects. Perhaps one approach is to focus on when and why you should use
> this call, rather than what it does:
> refAsOwnerDocument() / m_refCountAsOwnerDocument (or
> m_ownerDocumentRefCount)
> refAvoidingCycles() (or cycleAvoidingRef()) / m_cycleAvoidingRefCount

We probably need to qualify kinds of cycles we're avoiding: ones through
descendents (or subtree); e.g. this doesn't avoid cycles with JSC/V8

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120615/93903d9b/attachment.html>

More information about the webkit-dev mailing list