darin at apple.com
Wed Jun 13 15:27:44 PDT 2012
On Jun 13, 2012, at 2:24 PM, Myles C. Maxfield <myles.maxfield at gmail.com> wrote:
> There is still the question of if I can upstream this to ICU, which I'm checking on.
I was not proposing changing ICU.
> In the meantime, Ryosuke Niwa has a good argument for option 3) above.
Yes, that’s what I was suggesting; I am glad that Ryosuke stated it more clearly than I did.
> I have uploaded a new patch to https://bugs.webkit.org/show_bug.cgi?id=88936 that moves the NULL pointer check to inside the ICU-specific collator class.
Seems good. Not sure it should be a null pointer check, though. A zero length check would work too.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev