[webkit-dev] build.webkit.org down for upgrade

Lucas Forschler lforschler at apple.com
Tue Jun 12 11:00:42 PDT 2012


Hi Ossy,

Can you send me the bugzilla link for the ForceScheduler work?

Thanks,
Lucas

On May 31, 2012, at 9:22 AM, Lucas Forschler wrote:

> HI Ossy,
> 
> I did notice the display order change as well.  I think I am going to open a bug to rename all of the Apple bots to prefix them with 'Apple'.  We (at Apple) would like to get our bots into a more conforming naming convention.  I realize that won't solve the problem with having a specific order for your bots, but it will at least get everything grouped together.
> 
> I'm slightly opposed to rolling out the natural sorting as you suggest below… I think that will be short-lived and when buildbot 0.9.x is available, we may not have this option.  I think we should be forward thinking here and try not to work around this.  I can be convinced to make the change if there is additional support for rolling out the natural sorting.
> 
> Thanks for looking into the ForceScheduler.  Hopefully we can get that up and running quickly.
> 
> So far it appears we don't have any bots stuck in trigger mode.  Please let me know if you see any.  I am hoping that issue is now solved for good.
> 
> Thanks,
> Lucas
> 
> 
> 
> 
> On May 31, 2012, at 3:32 AM, Osztrogonac Csaba wrote:
> 
>> Lucas Forschler írta:
>>> to 0.8.6p1
>>> Will be back online when complete.
>>> Lucas
>> 
>> Hi All,
>> 
>> Unfortunately there are too annoying bugs introduced
>> with upgrading build master to 0.8.6p1 :
>> 
>> Problem 1
>> ----------
>> Builders are alphabetically ordered on http://build.webkit.org/waterfall
>> instead of the given order in our config.json.
>> 
>> http://buildbot.net/buildbot/docs/0.8.6p1/release-notes.html
>> "Builders are no longer displayed in the order they were configured. This was never
>> intended behavior, and will become impossible in the distributed architecture planned
>> for Buildbot-0.9.x. As of 0.8.6p1, builders are sorted naturally: lexically, but with
>> numeric segments sorted numerically."
>> 
>> I think the new alphabetical order is so confusing. For example Apple's Lion bots
>> are between GTK and Qt bots, but SnowLeopard bots are after the Qt bots. I know
>> that we can see category=AppleMac, category=Qt, ... , but the order of the bots
>> in a given category is important for us too.  I don't think that an artifical
>> renaming would be a good solution to get the order what we want. (Because we
>> would have to rename bots in all scripts, we would have loose the history, ...)
>> 
>> What about if we revert the buildbot-0.8.6p1 change in buildmaster caused this bug/feature?
>> Here is a simple patch to do it:
>> 
>> diff --git a/buildbot-0.8.6p1/buildbot/status/master.py b/buildbot-0.8.6p1/buildbot/status/master.py
>> index e803133..e60ab06 100644
>> --- a/buildbot-0.8.6p1/buildbot/status/master.py
>> +++ b/buildbot-0.8.6p1/buildbot/status/master.py
>> @@ -200,7 +200,7 @@ class Status(config.ReconfigurableServiceMixin, service.MultiService):
>> 
>>    def getBuilderNames(self, categories=None):
>>        if categories == None:
>> -            return util.naturalSort(self.botmaster.builderNames) # don't let them break it
>> +            return self.botmaster.builderNames # don't let them break it
>> 
>>        l = []
>>        # respect addition order
>> @@ -208,7 +208,7 @@ class Status(config.ReconfigurableServiceMixin, service.MultiService):
>>            bldr = self.botmaster.builders[name]
>>            if bldr.config.category in categories:
>>                l.append(name)
>> -        return util.naturalSort(l)
>> +        return l
>> 
>>    def getBuilder(self, name):
>>        """
>> 
>> Problem 2
>> ----------
>> There isn't force build possibility anymore.
>> 
>> http://buildbot.net/buildbot/docs/0.8.6p1/release-notes.html
>> "Forced builds now require that a ForceScheduler be defined in the Buildbot configuration."
>> 
>> It can be solved simple with adding ForceScheduler. I'm going
>> to file a bug report and prepare a patch to fix it soon.
>> 
>> br,
>> Ossy
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



More information about the webkit-dev mailing list