[webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

[Ojan Vafai]

I don't think there is any consistency across the project here except
everyone agrees that imported test suites shouldn't go in fast, e.g. all
our new flexbox tests have gone in css3/flexbox.

On Mon, Jun 11, 2012 at 10:28 PM, James Robinson <jamesr at google.com> wrote:

> There are plenty of non-text tests in fast/, even entire directories of
> them (fast/repaint). My understanding of the meaning of fast/ is that it is
> where new tests that are not imported should go. This meaning is not
> universally applied.
>
> - James
> On Jun 11, 2012 7:33 PM, "Mike Lawther" <mikelawther at chromium.org> wrote:
>
>> I'm the guy that added css3/calc tests.
>>
>> I did so because I not all my tests are 'text only' tests, but I still
>> wanted them all together. My understanding was that the 'fast' directory
>> was intended for 'text only' tests only.
>>
>> Does having the 'fast' directory still serve a useful purpose? I reckon
>> the original intent could be pushed into the tools, eg have a
>> 'new-run-webkit-tests --fast', which will only run text-only tests. Then
>> the developer adding new tests doesn't have to worry about where to put
>> them.
>>
>>     mike
>>
>> On 11 June 2012 18:57, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>
>>> Hi,
>>>
>>> I realized that there are a whole bunch of tests in LayoutTests/css3
>>> that use layoutTestController (e.g. css3/calc, css3/filters, etc...), which
>>> appears to mean that they're our own tests. However, css3/selectors3 is an
>>> imported W3C test suite. It's very confusing to mix imported tests and
>>> WebKit's own tests. Can we put the imported W3C tests in imported-w3c
>>> directory as proposed earlier?
>>>
>>> Best,
>>> Ryosuke Niwa
>>> Software Engineer
>>> Google Inc.
>>>
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120611/606fb784/attachment.html>