[webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

[Maciej Stachowiak]

On Jun 11, 2012, at 6:06 PM, Maciej Stachowiak <mjs at apple.com> wrote:

>  not a self-only reference (at some point renamed to guardRef). 

BTW I was able to find where it was renamed but not a good explanation of why. I think selfOnlyRef() was a much clearer name.

The history seems to be that it was renamed when moved from Document to TreeScope (without explanation in the bug or ChangeLog, and apparently retaining it's self-only referencing behavior per comments):

    http://trac.webkit.org/changeset/82882
    https://bugs.webkit.org/show_bug.cgi?id=57689

Then later it was moved back to Document but retaining the rename:

    http://trac.webkit.org/changeset/83123
    https://bugs.webkit.org/show_bug.cgi?id=57994

Would anyone object if I renamed it back? Alternately, could the reason for the new name be documented somewhere?

Regards,
Maciej