[webkit-dev] can we stop using Skipped files?
rniwa at webkit.org
Fri Jun 8 13:43:37 PDT 2012
On Fri, Jun 8, 2012 at 1:41 PM, Ojan Vafai <ojan at chromium.org> wrote:
> On Fri, Jun 8, 2012 at 1:37 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> On Fri, Jun 8, 2012 at 1:27 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>>> Most of these abstractions were either added to make testing easier
>>> (and faster since we didn't have to write to a real filesystem)
>> That sounds like a bad idea.
> FWIW, I thought so at first as well, but as I've worked with the
> FileSystem abstraction, I've found it to be very helpful and provide almost
> no extra abstraction burden since it tries to closely match the Python APIs.
It's extra code we have to read. For testing, we can just directly mock the
native filesystem classes & methods Python provides.
In general, I agree with Filip's sentiment that we have way too much code.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev