[webkit-dev] can we stop using Skipped files?

[Ryosuke Niwa]

On Fri, Jun 8, 2012 at 1:41 PM, Ojan Vafai <ojan at chromium.org> wrote:

> On Fri, Jun 8, 2012 at 1:37 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> On Fri, Jun 8, 2012 at 1:27 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>>>
>>> Most of these abstractions were either added to make testing easier
>>> (and faster since we didn't have to write to a real filesystem)
>>>
>>
>> That sounds like a bad idea.
>>
>
> FWIW, I thought so at first as well, but as I've worked with the
> FileSystem abstraction, I've found it to be very helpful and provide almost
> no extra abstraction burden since it tries to closely match the Python APIs.
>

It's extra code we have to read. For testing, we can just directly mock the
native filesystem classes & methods Python provides.

In general, I agree with Filip's sentiment that we have way too much code.

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120608/2d26f3a4/attachment.html>