[webkit-dev] Defaulting --exit-after-n-failures to 0
ojan at chromium.org
Fri Jun 8 13:38:03 PDT 2012
On Fri, Jun 8, 2012 at 12:46 PM, Dirk Pranke <dpranke at chromium.org> wrote:
> On Fri, Jun 8, 2012 at 12:44 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> > On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke <dpranke at chromium.org>
> >> I have no objection either to increasing the defaults for either of
> >> these numbers or making it possible to have different defaults per
> >> port.
> >> Do you want to suggest different defaults? Should we use ORWT's
> >> (infinite failures and infinite crashes by default)?
> > Unbounded failures & crashes sound good to me although I can definitely
> > a value in passing some fixed value on bots so as to reduce the cycle
> > when 10,000+ tests start to crash. Something like 100, 300, or 500 would
> > probably be acceptable.
> NRWT defaults to 500 failures, so you're suggesting we just up the
> default # of crashes to 500? Anyone have any other numbers jumping out
> at them?
I'm OK with the ORWT defaults of infinite for both. Then we never have to
have this discussion again. :) It can be on the buildbot maintainers to
pass in the right flags. All of the non-chromium ports already do anyways
as best I can tell.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev