[webkit-dev] can we stop using Skipped files?
dpranke at chromium.org
Fri Jun 8 13:27:13 PDT 2012
On Fri, Jun 8, 2012 at 1:16 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> I don't think that's true from my experience working on webkitpy so far. The
> root of problem is that we support way too many configurations & platforms,
> and Chromium port has had a completely different test runner program called
> test_shell. We've mostly transitioned (except Mac?) to DumpRenderTree at
> this point, but that has added a lot of code complexity (it probably
> accounts 20-30% if not 40-50% of all the code in layout_tests).
Nope, supporting the old test-shell mode is only about 300 lines of
code :). We support a lot of configurations and platforms, of course,
but so does ORWT.
> We also have a lot of abstractions around filesystem, etc... in
> webkitpy/common, which I'm not a big fun of. I think some of that is
> inherited from the era where we had to use some features that weren't
> supported in Python 2.5. Now that we no longer support Python 2.5, we can
> probably cleanup some of that mess.
Most of these abstractions were either added to make testing easier
(and faster since we didn't have to write to a real filesystem) or to
make the code more portable (e.g., to deal with the differences
between windows filenames and unix filenames). Python 2.4 and 2.5 had
little to do with it. These abstractions are used by the other tools
like webkit-patch as well.
More information about the webkit-dev