[webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

[Ryosuke Niwa]

On Sun, Jun 3, 2012 at 1:45 PM, Maciej Stachowiak <mjs at apple.com> wrote:

> Already done for the WebKit2 WebKitTestRunner. It should be
> straightforward to adapt its IDL compiler.
>

I've considered adapting WebKitTestRunner's code generator, but it appeared
quite tricky because ports don't share much code in DumpRenderTree unlike
WebKitTestRunner so we end up having to significantly modify each port's
build configuration files for DumpRenderTree. Also, WebKitTestRunner's code
generator only supports JSC at the moment, and supporting V8 there will
require a significant work and might clutter the codebase.

Given that, the approach I'm taking in
https://bugs.webkit.org/show_bug.cgi?id=88183 at the moment is re-use
Internals object's infrastructure. So I'm defining
LayoutTestControllerBase.idl (interfaceName=LayoutTestController) and
LayoutTestControllerBase.h/cpp in WebCore, and letting LayoutTestController
in DumpRenderTree override it.

One big advantage of this approach is that code generator in WebCore
already supports JSC and V8, so we'll be able to share more code between
JSC & V8 implementations of LayoutTestController. In fact, my current plan
is to replace all usage of JSStringRef, etc... (and their V8 equivalents)
by std::string so that they can be identical between two implementations.

Of course, one big disadvantage is that we'll be introducing a separate IDL
file for LayoutTestController. However, it appears that we can use the same
object injection mechanism for WebKitTestRunner as well. So I'm hopeful
that we can ultimately share IDLs between DumpRenderTree and
WebKitTestRunner.

What do you think of this approach?

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120603/343a6bb1/attachment.html>