[webkit-dev] impending changes to how new-run-webkit-tests prints/logs stuff

[Dirk Pranke]

On Tue, Jul 31, 2012 at 7:02 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Tue, Jul 31, 2012 at 6:59 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>>
>> On Tue, Jul 31, 2012 at 6:36 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> > On Tue, Jul 31, 2012 at 6:29 PM, Dirk Pranke <dpranke at chromium.org>
>> > wrote:
>> >>
>> >> I'm finally getting around to cleaning up the byzantine mass of
>> >> options in new-run-webkit-tests that controls what gets printed to
>> >> stderr and stdout during a test run.
>> >>
>> >> The patch is posted in https://bugs.webkit.org/show_bug.cgi?id=92432.
>> >> To quote the changelog:
>> >>
>> >> [All of the --print X,Y,Z options are] replaced by five printing
>> >> modes/options:
>> >>
>> >> 1) by default, we print some configuration information, errors,
>> >> warnings, and a progress bar. We didn't use to print the configuration
>> >> information by default, and I've found that (a) it's really useful and
>> >> (b) most people didn't know about it. However, if you don't want that
>> >> output, use ...
>> >>
>> >> 2) if --quiet is passed, we don't print the configuration information
>> >> (this was the default before)
>> >>
>> >> 3) if --verbose is specified once, you will get a one-line-per test
>> >> summary in addition to the default output of (1). This is close to the
>> >> --verbose mode from ORWT and is probably more useful than the older
>> >> form of --verbose, which printed out a lot more debug-type stuff. To
>> >> get the debug-type stuff ...
>> >>
>> >> 4) if --verbose is specified twice, you get the old-style debug log
>> >> output
>> >>
>> >> And, if you used to use the obscure but occasionally really helpful
>> >> --print trace-everything flag:
>> >>
>> >> 5) if --details is specified, you get the per-test details you used to
>> >> get with --print trace-everything or --print trace-unexpected.
>> >> --details handling is largely independendent of --quiet/--verbose.
>> >
>> >
>> > We've still got too many --verbose/--details options.
>> >
>> > Can we just combine two --verbose and --details or remove one of them
>> > and
>> > call it --debug?
>> >
>>
>> I'm not sure if I understand your suggestion. Are you suggesting we
>> call --details --debug instead? or have --verbose --verbose be
>> replaced by --debug?
>
>
> My suggestion is to merge --verbose --verbose and --details into one option:
> --debug.

Right, I wouldn't want to do that; it would make the already-too-big
bot output 6x bigger, I'm guessing.

>> We definitely don't want --details to be enabled by default either
>> interactively or on the bots; it logs way too much if you're running a
>> lot of tests. I also personally would not want to have to slog through
>> the debug output to extract the stuff that --details will print.
>>
>> I would be fine with changing '--verbose --verbose' to '--debug', but
>> I'm not sure if that's either much of an improvement or enough to make
>> you happy?
>
>
> So we need to have --verbose --verbose separately from --verbose and
> --details to be used on bots? Why don't we get rid of single --verbose then?

ap@ and others have requested a single --verbose that is closer to
what ORWT used to do (bug 88702); something more than what we get by
default, but less verbose than either what --details or
--verbose/--debug would be.

-- Dirk