[webkit-dev] [123877] trunk/Tools

[William Siegrist]

BTW, I believe this is fixed, I am just waiting for another CQ commit to verify. 

-Bill



On Jul 28, 2012, at 6:14 AM, Patrick Gansterer <paroga at paroga.com> wrote:

> But the author rewrite hook for commit-queue at webkit.org does not work.
> 
> -- Patrick
> 
> On Fri, 27 Jul 2012 09:33:49 -0700, William Siegrist wrote:
>> Sorry about that, put the wrong address in the new hook. :( Should be
>> fixed now.
>> 
>> -Bill
>> 
>> 
>> 
>> On Jul 27, 2012, at 9:30 AM, Brady Eidson <beidson at apple.com> wrote:
>> 
>>> Why did this get sent to webkit-dev instead of webkit-changes?
>>> 
>>> (Maybe a result of this morning's migration?)
>>> 
>>> ~Brady
>>> 
>>> On Jul 27, 2012, at 9:22 AM, kbalazs at webkit.org wrote:
>>> 
>>>> Revision
>>>> 123877
>>>> Author
>>>> kbalazs at webkit.org
>>>> Date
>>>> 2012-07-27 09:22:06 -0700 (Fri, 27 Jul 2012)
>>>> Log Message
>>>> 
>>>> [NRWT] should have a way to restrict pixel tests for individual directories
>>>> 
>>>> https://bugs.webkit.org/show_bug.cgi?id=91754
>>>> 
>>>> 
>>>> Unreviewed attempt to fix the chaos I introduced.
>>>> 
>>>> * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
>>>> (WebCore::DumpRenderTree::processLine):
>>>> 
>>>> Modified Paths
>>>> 
>>>> 	• trunk/Tools/ChangeLog
>>>> 	• trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
>>>> Diff
>>>> 
>>>> Modified: trunk/Tools/ChangeLog (123876 => 123877)
>>>> 
>>>> --- trunk/Tools/ChangeLog	2012-07-27 14:15:24 UTC (rev 123876)
>>>> +++ trunk/Tools/ChangeLog	2012-07-27 16:22:06 UTC (rev 123877)
>>>> 
>>>> @@ -1,3 +1,13 @@
>>>> 
>>>> +2012-07-27  Balazs Kelemen  <kbalazs at webkit.org
>>>> >
>>>> +
>>>> +        [NRWT] should have a way to restrict pixel tests for individual directories
>>>> +
>>>> https://bugs.webkit.org/show_bug.cgi?id=91754
>>>> 
>>>> +
>>>> +        Unreviewed attempt to fix the chaos I introduced.
>>>> +
>>>> +        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
>>>> +        (WebCore::DumpRenderTree::processLine):
>>>> +
>>>> 
>>>> 2012-07-27  YoungTaeck Song  <youngtaeck.song at samsung.com
>>>> >
>>>> 
>>>> 
>>>> 
>>>>         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
>>>> 
>>>> Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (123876 => 123877)
>>>> 
>>>> --- trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp	2012-07-27 14:15:24 UTC (rev 123876)
>>>> +++ trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp	2012-07-27 16:22:06 UTC (rev 123877)
>>>> 
>>>> @@ -696,7 +696,7 @@
>>>> 
>>>>     m_expectedHash = QString();
>>>> 
>>>>     // single quote marks the pixel dump hash
>>>> 
>>>>     int indexOfFirstSeparator = line.indexOf('\'');
>>>> 
>>>> -    int indexOfSecondSeparator = line.indexOf('\'', indexOfFirstSeparator);
>>>> 
>>>> +    int indexOfSecondSeparator = line.indexOf('\'', indexOfFirstSeparator + 1);
>>>> 
>>>>     if (indexOfFirstSeparator > -1) {
>>>> 
>>>>         int indexOfPixelHash = indexOfFirstSeparator + 1;
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>> 
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev