[webkit-dev] Removing --pixel-tests from DRT/WTR
kbalazs at webkit.org
Thu Jul 26 11:00:14 PDT 2012
I am going to upload a patch to
<https://bugs.webkit.org/show_bug.cgi?id=92398> that will remove the
--pixel-tests option from test drivers. Don't worry, I don't want to
kill pixel testing, I want to be able to control it per test so we can
filter what tests to run as pixel tests. I already implemented it in
http://trac.webkit.org/changeset/123729 for WebKitTestRunner and Qt DRT,
so now those drivers accept an optional '--pixel-test' arg after the
test name so the test harness can specify whether to dump pixels for
each test separately. (Note that the hash is not enough because there
are cases when we may want to run pixel tests but we don't pass the
hash, like with --reset-results or when the expected image is missing.)
Now I'm going to make it work for every DRT, and after that there will
be no need for the --pixel-tests command line option.
But there is a question that I should ask first: is there anybody
relying on running DRT manually, and passing --pixel-tests on the
command line? Do you think it can be useful? (Maybe for debugging?)
There is no technical problem of keeping it for this use case but I
think it's better to remove if there is no strong need for it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev