[webkit-dev] Web APIs and class name collisions

[Eric Seidel]

I would go with CSSRegion, and stick it in the css/ folder.  Much of
the CSS folder is our implementation of the CSS Object Model (CSSOM).
At some point it might make sense to pull all the classes which
implement the CSSOM out of css/ into a new cssom/ similar to dom/, but
that's a later discussion.

-eric

On Thu, Jul 12, 2012 at 10:03 AM, Andrei Bucur <abucur at adobe.com> wrote:
> From my knowledge the "CSS" prefix is reserved for the CSS engine classes in
> WebKit. Prefixing the Region class with "CSS" could prove confusing.
>
> Regards,
> Andrei.
>
> From: Alan Stearns <stearns at adobe.com>
> Date: Thursday, July 12, 2012 7:39 PM
> To: Adam Barth <abarth at webkit.org>, Andrei Bucur <abucur at adobe.com>
>
> Cc: "webkit-dev at lists.webkit.org" <webkit-dev at lists.webkit.org>
> Subject: Re: [webkit-dev] Web APIs and class name collisions
>
> The spec itself consistently and deliberately calls them "CSS Regions," so a
> CSS prefix could be appropriate.
>
> Thanks,
>
> Alan
>
>
> From: Adam Barth <abarth at webkit.org>
> To: Andrei Bucur <abucur at adobe.com>
> Cc: "webkit-dev at lists.webkit.org" <webkit-dev at lists.webkit.org>
> Subject: Re: [webkit-dev] Web APIs and class name collisions
>
> One common thing we do is prefix "DOM" to DOM-level concepts.  For example,
> DOMWindow and DOMFileSystem.  I'm not sure if we have an established
> convention for CSS-level concepts.
>
> Adam
>
>
> On Thu, Jul 12, 2012 at 9:18 AM, Andrei Bucur <abucur at adobe.com> wrote:
>>
>> Hello Webkittens!
>>
>> While implementing the Region interface (
>> http://dev.w3.org/csswg/css3-regions/#the-region-interface ) I've noticed
>> that the name "Region" is already taken by a class in platform/graphics. I'd
>> like to know what's the best approach in these kind of situations:
>>
>> Rename the existing WebCore class to something else and use the name
>> "Region" for the Web API so there's parity between the implementation and
>> the spec
>> Somehow prefix the Web API implementation class name?
>>
>> As the Web APIs expand I suppose this situation may occur again in the
>> future and I suppose there should be a rule describing what's the best
>> approach to take.
>>
>> Thanks!
>> Andrei.
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>